adesh-rao commented on a change in pull request #1275:
URL: https://github.com/apache/hive/pull/1275#discussion_r458940334
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -89,23 +93,28 @@ public void run() {
handle =
txnHandler.getMutexAPI().acquireLock(TxnStore.MUTEX_KEY.Cleaner.name());
startedAt = System.currentTimeMillis();
long minOpenTxnId = txnHandler.findMinOpenTxnIdForCleaner();
+ List<CompletableFuture> cleanerList = new ArrayList<>();
for(CompactionInfo compactionInfo : txnHandler.findReadyToClean()) {
- clean(compactionInfo, minOpenTxnId);
+
cleanerList.add(CompletableFuture.runAsync(CompactorUtil.ThrowingRunnable.unchecked(()
->
+ clean(compactionInfo, minOpenTxnId)), cleanerExecutor));
}
+ CompletableFuture.allOf(cleanerList.toArray(new
CompletableFuture[0])).join();
} catch (Throwable t) {
LOG.error("Caught an exception in the main loop of compactor cleaner,
" +
- StringUtils.stringifyException(t));
- }
- finally {
+ StringUtils.stringifyException(t));
+ if (cleanerExecutor != null) {
Review comment:
Agreed. I have removed the executor shutdown.
But where/should we add executor shutdown? I think since the Cleaner is
supposed to be running all the time. We can skip executor shutdown?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
