pkumarsinha commented on a change in pull request #1289:
URL: https://github.com/apache/hive/pull/1289#discussion_r458964119
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/metric/ReplicationMetricCollector.java
##########
@@ -77,6 +77,9 @@ public void reportStageEnd(String stageName, Status status,
long lastReplId) thr
Stage stage = progress.getStageByName(stageName);
stage.setStatus(status);
stage.setEndTime(System.currentTimeMillis());
+ if (Status.FAILED == status) {
Review comment:
Could you please give background of this?
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AtlasDumpTask.java
##########
@@ -79,6 +80,7 @@ public AtlasDumpTask() {
@Override
public int execute() {
try {
+ SecurityUtils.reloginExpiringKeytabUser();
Review comment:
Should it be more closure to the actual usage. Meaning, if we are doing
a retry inside the task(Repl/Ranger/Atlas) somewhere, should it be closer to
where we are actually interacting with external system?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
