pvary commented on a change in pull request #1288:
URL: https://github.com/apache/hive/pull/1288#discussion_r459371170



##########
File path: ql/src/java/org/apache/hadoop/hive/llap/ProactiveEviction.java
##########
@@ -229,12 +230,59 @@ public String getSingleDbName() {
     }
 
     /**
-     * Match a CacheTag to this eviction request.
+     * Match a CacheTag to this eviction request. Must only be used on LLAP 
side only, where the received request may

Review comment:
       Why is this checked here, and not at construction time, or when we 
receive / parse the request? This seems a little awkward for me.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to