maheshk114 commented on a change in pull request #1147:
URL: https://github.com/apache/hive/pull/1147#discussion_r459988214
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdDistinctRowCount.java
##########
@@ -79,6 +80,11 @@ public Double getDistinctRowCount(HiveSemiJoin rel,
RelMetadataQuery mq, Immutab
return super.getDistinctRowCount(rel, mq, groupKey, predicate);
}
+ public Double getDistinctRowCount(HiveAntiJoin rel, RelMetadataQuery mq,
ImmutableBitSet groupKey,
+ RexNode predicate) {
+ return super.getDistinctRowCount(rel, mq, groupKey, predicate);
Review comment:
calcite 21 does not support distinct calculation for Anti join.
if (join.isSemiJoin()) {
return getSemiJoinDistinctRowCount(join, mq, groupKey, predicate);
} else {
Builder leftMask = ImmutableBitSet.builder();
I think these rules will not get triggered as of now for Anti join as i am
not converting the not-exists to anti join. As of now all these rules will be
applied on left outer and then we convert the left outer to anti join.
I
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
