vineetgarg02 commented on a change in pull request #1265:
URL: https://github.com/apache/hive/pull/1265#discussion_r460141221
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##########
@@ -4007,9 +4007,17 @@ public boolean getPartitionsByExpr(Table tbl,
ExprNodeGenericFuncDesc expr, Hive
if (AcidUtils.isTransactionalTable(tbl)) {
validWriteIdList = getValidWriteIdList(tbl.getDbName(),
tbl.getTableName());
}
- boolean hasUnknownParts =
getMSC().listPartitionsSpecByExpr(tbl.getDbName(),
- tbl.getTableName(), exprBytes, defaultPartitionName, (short)-1,
msParts,
- validWriteIdList != null ? validWriteIdList.toString() : null);
+
+ PartitionsByExprRequest req = new
PartitionsByExprRequest(tbl.getDbName(), tbl.getTableName(),
Review comment:
It will be good to encapsulate creation of `PartitionsByExprRequest` is
a separate method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
