pvary commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r464311382
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java
##########
@@ -1641,28 +1645,26 @@ public int compareTo(CompressedOwid other) {
* Check if the delete delta folder needs to be scanned for a given
split's min/max write ids.
*
* @param orcSplitMinMaxWriteIds
- * @param deleteDeltaDir
+ * @param deleteDelta
+ * @param stmtId statementId of the deleteDelta if present
* @return true when delete delta dir has to be scanned.
*/
@VisibleForTesting
protected static boolean
isQualifiedDeleteDeltaForSplit(AcidOutputFormat.Options orcSplitMinMaxWriteIds,
- Path deleteDeltaDir)
- {
- AcidUtils.ParsedDelta deleteDelta =
AcidUtils.parsedDelta(deleteDeltaDir, false);
+ AcidInputFormat.DeltaMetaData deleteDelta, Integer stmtId) {
Review comment:
nit: extra spaces?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
