pgaref commented on a change in pull request #1291: URL: https://github.com/apache/hive/pull/1291#discussion_r465899362
########## File path: llap-common/src/test/org/apache/hadoop/hive/llap/AsyncResponseHandlerTest.java ########## @@ -0,0 +1,222 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.llap; + +import com.google.protobuf.Message; +import org.apache.hadoop.hive.llap.AsyncPbRpcProxy.ExecuteRequestCallback; +import org.apache.hadoop.util.concurrent.AsyncGet; +import org.junit.After; +import org.junit.Before; +import org.junit.Test; + +import java.util.Random; +import java.util.concurrent.TimeUnit; + +import static java.lang.Thread.sleep; +import static org.mockito.Matchers.any; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.times; +import static org.mockito.Mockito.verify; + +public class AsyncResponseHandlerTest { Review comment: Hey @mustafaiman -- I remember spending time in the past for a test that did not trigger because of naming and wanted to make sure we dont hit that issue. You are right though, both Test* and *Test should be fine and since it run fine we are good :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
