vineetgarg02 commented on a change in pull request #1315:
URL: https://github.com/apache/hive/pull/1315#discussion_r466533366
##########
File path: ql/src/test/results/clientpositive/llap/udf_greatest.q.out
##########
@@ -63,7 +63,7 @@ STAGE PLANS:
alias: src
Row Limit Per Split: 1
Select Operator
- expressions: 'c' (type: string), 'a' (type: string), 'AaA' (type:
string), 'AAA' (type: string), '13' (type: string), '2' (type: string), '03'
(type: string), '1' (type: string), null (type: double), null (type: double),
null (type: double), null (type: double), null (type: double), null (type:
double)
Review comment:
There is a small change in the patch which updates the type inference
rule for void/null. Prior to the change the expressions were being inferred as
`Double` in this case. With the change it is appropriately inferred as `String`
(since rest of the expressions within this UDF (`GREATEST('a', 'b', null )`) is
interpreted as string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
