pkumarsinha commented on a change in pull request #1358:
URL: https://github.com/apache/hive/pull/1358#discussion_r466576634
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AtlasDumpTask.java
##########
@@ -196,12 +203,14 @@ private String checkHiveEntityGuid(AtlasRequestBuilder
atlasRequestBuilder, Stri
AtlasObjectId objectId = atlasRequestBuilder.getItemToExport(clusterName,
srcDb);
Set<Map.Entry<String, Object>> entries =
objectId.getUniqueAttributes().entrySet();
if (entries == null || entries.isEmpty()) {
- throw new SemanticException("Could find entries in objectId for:" +
clusterName);
+ throw new
SemanticException(ErrorMsg.REPL_INVALID_CONFIG_FOR_SERVICE.format("Could find "
+
+ "entries in objectId for:" + clusterName, "atlas"));
Review comment:
was referring to "atlas" part here and in other places like "ranger",
"hive" . Should we have one const defined per service and use that in stead?,
something like:
final String ReplUtils.ATLAS_SVC = "atlas";
ErrorMsg.REPL_INVALID_CONFIG_FOR_SERVICE.format("Could find " +
"entries in objectId for:" + clusterName, ReplUtils.ATLAS_SVC);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
