maheshk114 commented on a change in pull request #1147:
URL: https://github.com/apache/hive/pull/1147#discussion_r466819572
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinAddNotNullRule.java
##########
@@ -92,7 +104,7 @@ public void onMatch(RelOptRuleCall call) {
Set<String> rightPushedPredicates =
Sets.newHashSet(registry.getPushedPredicates(join, 1));
boolean genPredOnLeft = join.getJoinType() == JoinRelType.RIGHT ||
join.getJoinType() == JoinRelType.INNER || join.isSemiJoin();
- boolean genPredOnRight = join.getJoinType() == JoinRelType.LEFT ||
join.getJoinType() == JoinRelType.INNER || join.isSemiJoin();
+ boolean genPredOnRight = join.getJoinType() == JoinRelType.LEFT ||
join.getJoinType() == JoinRelType.INNER || join.isSemiJoin()||
join.getJoinType() == JoinRelType.ANTI;
Review comment:
yes ..that is taken care of.
// For anti join, we should proceed to emit records if the right side is
empty or not matching.
if (type == JoinDesc.ANTI_JOIN && !producedRow) {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
