pvary commented on a change in pull request #1382:
URL: https://github.com/apache/hive/pull/1382#discussion_r475189153
##########
File path:
streaming/src/java/org/apache/hive/streaming/AbstractRecordWriter.java
##########
@@ -581,16 +582,9 @@ protected RecordUpdater getRecordUpdater(List<String>
partitionValues, int bucke
destLocation = new Path(table.getSd().getLocation());
} else {
PartitionInfo partitionInfo =
conn.createPartitionIfNotExists(partitionValues);
- // collect the newly added partitions.
connection.commitTransaction() will report the dynamically added
- // partitions to TxnHandler
- if (!partitionInfo.isExists()) {
- addedPartitions.add(partitionInfo.getName());
- } else {
- if (LOG.isDebugEnabled()) {
- LOG.debug("Partition {} already exists for table {}",
- partitionInfo.getName(), fullyQualifiedTableName);
- }
- }
+ // collect the newly added/updated partitions.
connection.commitTransaction() will report the dynamically
+ // added partitions to TxnHandler
+ addedPartitions.add(partitionInfo.getName());
Review comment:
Can we please rename the 'addedPartitions' to something like more
resembling the actual usage, like 'updatedPartitions', or 'changedPartitions',
or whatever? Maybe a comment on the attribute/and getter should be good as well.
Otherwise LGTM.
Thanks, Peter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
