vihangk1 commented on a change in pull request #1391:
URL: https://github.com/apache/hive/pull/1391#discussion_r478721102



##########
File path: 
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/command/CommandAuthorizerV2.java
##########
@@ -121,6 +142,24 @@ private static void 
addPermanentFunctionEntities(SessionState ss, List<ReadEntit
     return hivePrivobjs;
   }
 
+  private static boolean isDeferredAuthView(Table t){
+    String tableType = t.getTTable().getTableType();
+    boolean isView = false;
+    if (TableType.MATERIALIZED_VIEW.name().equals(tableType) || 
TableType.VIRTUAL_VIEW.name().equals(tableType)) {
+      isView = true;
+    }
+    if(isView){
+      Map<String, String> params = t.getParameters();
+      if (params != null && params.containsKey("Authorized")) {
+        String authorized = params.get("Authorized");

Review comment:
       Instead of using a "Authorized" keyword, it is less error prone to 
create a constant and reuse it at all the places.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to