prasanthj commented on a change in pull request #1418: URL: https://github.com/apache/hive/pull/1418#discussion_r480371903
########## File path: llap-common/src/java/org/apache/hadoop/hive/llap/security/DefaultJwtSharedSecretProvider.java ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.llap.security; + +import com.google.common.base.Preconditions; +import io.jsonwebtoken.security.Keys; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hive.conf.HiveConf; + +import java.io.IOException; +import java.nio.ByteBuffer; +import java.nio.CharBuffer; +import java.nio.charset.StandardCharsets; +import java.security.Key; + +import static org.apache.hadoop.hive.conf.HiveConf.ConfVars.LLAP_EXTERNAL_CLIENT_CLOUD_DEPLOYMENT_SETUP_ENABLED; +import static org.apache.hadoop.hive.conf.HiveConf.ConfVars.LLAP_EXTERNAL_CLIENT_CLOUD_JWT_SHARED_SECRET; + +/** + * Default implementation of {@link JwtSecretProvider}. + * + * 1. It first tries to get shared secret from conf {@link HiveConf.ConfVars#LLAP_EXTERNAL_CLIENT_CLOUD_JWT_SHARED_SECRET} + * using {@link Configuration#getPassword(String)}. + * + * 2. If not found, it tries to read from env var {@link #LLAP_EXTERNAL_CLIENT_CLOUD_JWT_SHARED_SECRET_ENV_VAR}. + * + * If secret is not found even after 1) and 2), {@link #init(Configuration)} methods throws {@link NullPointerException}. + * + * It uses the same encryption and decryption secret which can be used to sign and verify JWT. + */ +public class DefaultJwtSharedSecretProvider implements JwtSecretProvider { + + public static final String LLAP_EXTERNAL_CLIENT_CLOUD_JWT_SHARED_SECRET_ENV_VAR = + "LLAP_EXTERNAL_CLIENT_CLOUD_JWT_SHARED_SECRET_ENV_VAR"; + + private Key jwtEncryptionKey; + + @Override public Key getEncryptionSecret() { + return jwtEncryptionKey; + } + + @Override public Key getDecryptionSecret() { + return jwtEncryptionKey; + } + + @Override public void init(final Configuration conf) { + char[] sharedSecret; + byte[] sharedSecretBytes = null; + + // try getting secret from conf first + // if not found, get from env var - LLAP_EXTERNAL_CLIENT_CLOUD_JWT_SHARED_SECRET_ENV_VAR + try { + sharedSecret = conf.getPassword(LLAP_EXTERNAL_CLIENT_CLOUD_JWT_SHARED_SECRET.varname); + } catch (IOException e) { + throw new RuntimeException("Unable to get password [hive.llap.external.client.cloud.jwt.shared.secret] - " + + e.getMessage(), e); + } + if (sharedSecret != null) { + ByteBuffer bb = StandardCharsets.UTF_8.encode(CharBuffer.wrap(sharedSecret)); + sharedSecretBytes = new byte[bb.remaining()]; + bb.get(sharedSecretBytes); + } else { + String sharedSecredFromEnv = System.getenv(LLAP_EXTERNAL_CLIENT_CLOUD_JWT_SHARED_SECRET_ENV_VAR); + if (sharedSecredFromEnv != null) { + sharedSecretBytes = sharedSecredFromEnv.getBytes(); + } + } + + Preconditions.checkNotNull(sharedSecretBytes, Review comment: nit: IllegalStateException is more appropriate I guess. check state instead? ########## File path: llap-common/src/java/org/apache/hadoop/hive/llap/security/DefaultJwtSharedSecretProvider.java ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.llap.security; + +import com.google.common.base.Preconditions; +import io.jsonwebtoken.security.Keys; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hive.conf.HiveConf; + +import java.io.IOException; +import java.nio.ByteBuffer; +import java.nio.CharBuffer; +import java.nio.charset.StandardCharsets; +import java.security.Key; + +import static org.apache.hadoop.hive.conf.HiveConf.ConfVars.LLAP_EXTERNAL_CLIENT_CLOUD_DEPLOYMENT_SETUP_ENABLED; +import static org.apache.hadoop.hive.conf.HiveConf.ConfVars.LLAP_EXTERNAL_CLIENT_CLOUD_JWT_SHARED_SECRET; + +/** + * Default implementation of {@link JwtSecretProvider}. + * + * 1. It first tries to get shared secret from conf {@link HiveConf.ConfVars#LLAP_EXTERNAL_CLIENT_CLOUD_JWT_SHARED_SECRET} + * using {@link Configuration#getPassword(String)}. + * + * 2. If not found, it tries to read from env var {@link #LLAP_EXTERNAL_CLIENT_CLOUD_JWT_SHARED_SECRET_ENV_VAR}. + * + * If secret is not found even after 1) and 2), {@link #init(Configuration)} methods throws {@link NullPointerException}. + * + * It uses the same encryption and decryption secret which can be used to sign and verify JWT. + */ +public class DefaultJwtSharedSecretProvider implements JwtSecretProvider { + + public static final String LLAP_EXTERNAL_CLIENT_CLOUD_JWT_SHARED_SECRET_ENV_VAR = + "LLAP_EXTERNAL_CLIENT_CLOUD_JWT_SHARED_SECRET_ENV_VAR"; + + private Key jwtEncryptionKey; + + @Override public Key getEncryptionSecret() { + return jwtEncryptionKey; + } + + @Override public Key getDecryptionSecret() { + return jwtEncryptionKey; + } + + @Override public void init(final Configuration conf) { + char[] sharedSecret; + byte[] sharedSecretBytes = null; + + // try getting secret from conf first + // if not found, get from env var - LLAP_EXTERNAL_CLIENT_CLOUD_JWT_SHARED_SECRET_ENV_VAR + try { + sharedSecret = conf.getPassword(LLAP_EXTERNAL_CLIENT_CLOUD_JWT_SHARED_SECRET.varname); + } catch (IOException e) { + throw new RuntimeException("Unable to get password [hive.llap.external.client.cloud.jwt.shared.secret] - " + + e.getMessage(), e); + } + if (sharedSecret != null) { + ByteBuffer bb = StandardCharsets.UTF_8.encode(CharBuffer.wrap(sharedSecret)); + sharedSecretBytes = new byte[bb.remaining()]; + bb.get(sharedSecretBytes); + } else { + String sharedSecredFromEnv = System.getenv(LLAP_EXTERNAL_CLIENT_CLOUD_JWT_SHARED_SECRET_ENV_VAR); + if (sharedSecredFromEnv != null) { Review comment: also check for empty string? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
