kishendas commented on a change in pull request #1443:
URL: https://github.com/apache/hive/pull/1443#discussion_r483168530



##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java
##########
@@ -1227,4 +1232,18 @@ private TGetInfoResp getServerInfo(TGetInfoType type) 
throws SQLException {
     Utils.verifySuccess(resp.getStatus());
     return resp;
   }
+
+  /**
+   * This returns Hive configuration for HIVE_DEFAULT_NULLS_LAST.
+   *
+   * @param hiveConfs
+   * @return
+   */
+  public static boolean getHiveDefaultNullsLast(Map<String, String> hiveConfs) 
{
+    boolean response = ConfVars.HIVE_DEFAULT_NULLS_LAST.defaultBoolVal;
+    if ((hiveConfs != null) && 
(hiveConfs.get(JdbcConnectionParams.HIVE_DEFAULT_NULLS_LAST_KEY) != null)) {

Review comment:
       I think there can be JDBC tests where hiveConf can come as null. I can 
change this and see how many tests fail. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to