abstractdog commented on a change in pull request #1379:
URL: https://github.com/apache/hive/pull/1379#discussion_r483607071
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java
##########
@@ -265,11 +279,70 @@ public URI apply(Path path) {
}
dag.addURIsForCredentials(uris);
}
+ getKafkaCredentials((MapWork)work, dag, conf);
}
-
getCredentialsForFileSinks(work, dag);
}
+ private void getKafkaCredentials(MapWork work, DAG dag, JobConf conf) {
+ Token<?> tokenCheck =
dag.getCredentials().getToken(KAFKA_DELEGATION_TOKEN_KEY);
+ if (tokenCheck != null) {
+ LOG.debug("Kafka credentials already added, skipping...");
+ return;
+ }
+ LOG.info("Getting kafka credentials for mapwork: " + work.getName());
+
+ String kafkaBrokers = null;
+ Map<String, PartitionDesc> partitions = work.getAliasToPartnInfo();
Review comment:
@ashutoshc : what do you think about this?
https://github.com/apache/hive/pull/1379/commits/edc4ad440af4e234b731104bbcb9837cbdf43a19#diff-d7b5b051769b68ed5dd602cc30744439R303-R306
(tested on cluster)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
