jcamachor commented on a change in pull request #1492:
URL: https://github.com/apache/hive/pull/1492#discussion_r496112152
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HivePointLookupOptimizerRule.java
##########
@@ -757,10 +752,15 @@ private static RexNode handleAND(RexBuilder rexBuilder,
RexCall call) {
}
}
// Create IN clauses
- final List<RexNode> newOperands = createInClauses(rexBuilder,
inLHSExprToRHSExprs);
+ final List<RexNode> newOperands = createInClauses(rexBuilder,
+ visitedRefs, inLHSExprToRHSExprs, inLHSExprToRHSNullableExprs);
newOperands.addAll(operands);
// Return node
- return RexUtil.composeConjunction(rexBuilder, newOperands, false);
+ RexNode result = RexUtil.composeConjunction(rexBuilder, newOperands,
false);
+ if (!result.getType().equals(call.getType())) {
Review comment:
Once again, good catch. This compensation was coming from a previous
version of the patch :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
