pvargacl commented on a change in pull request #1532:
URL: https://github.com/apache/hive/pull/1532#discussion_r498224776



##########
File path: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -3357,6 +3355,52 @@ private void truncateTableInternal(String dbName, String 
tableName, List<String>
       }
     }
 
+    /**
+     * Add an empty baseDir with a truncate metadatafile
+     * @param location
+     * @param writeId
+     * @param fs
+     * @throws Exception
+     */
+    private void addTruncateBaseFile(Path location, long writeId, FileSystem 
fs) throws Exception {
+      Path basePath = new Path(location, AcidConstants.baseDir(writeId));
+      fs.mkdirs(basePath);
+      // We can not leave the folder empty, otherwise it will be skipped at 
some file listing in AcidUtils
+      // No need for a data file, a simple metadata is enough

Review comment:
       added the write to the MetaDataFile and moved it out from the 
AcidConstants class




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to