zeroflag commented on a change in pull request #1542:
URL: https://github.com/apache/hive/pull/1542#discussion_r498868959
##########
File path:
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -2830,6 +2848,11 @@ PartitionsResponse
get_partitions_req(1:PartitionsRequest req)
void add_replication_metrics(1: ReplicationMetricList replicationMetricList)
throws(1:MetaException o1)
ReplicationMetricList get_replication_metrics(1:
GetReplicationMetricsRequest rqst) throws(1:MetaException o1)
GetOpenTxnsResponse get_open_txns_req(1: GetOpenTxnsRequest
getOpenTxnsRequest)
+
+ void create_stored_procedure(1: string catName, 2: StoredProcedure proc)
throws(1:NoSuchObjectException o1, 2:MetaException o2)
+ StoredProcedure get_stored_procedure(1: string catName, 2: string db, 3:
string name) throws (1:MetaException o1, 2:NoSuchObjectException o2)
+ void drop_stored_procedure(1: string catName, 2: string dbName, 3: string
funcName) throws (1:MetaException o1, 2:NoSuchObjectException o2)
+ list<StoredProcedure> get_all_stored_procedures(1: string catName) throws
(1:MetaException o1)
Review comment:
You mean putting (1: string catName, 2: string dbName, 3: string
funcName) into a request object? I can do that. But if we have only can
parameter, like in the last case that would be an overkill in my opinion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
