ashish-kumar-sharma commented on a change in pull request #1528: URL: https://github.com/apache/hive/pull/1528#discussion_r498901990
########## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java ########## @@ -130,6 +130,11 @@ public void alterTable(RawStore msdb, Warehouse wh, String catName, String dbnam throw new InvalidOperationException("Invalid column " + validate); } + // Validate bucketedColumns in new table + if (!MetaStoreServerUtils.validateBucketColumns(newt.getSd())) { + throw new InvalidOperationException("Bucket column doesn't match with any table columns"); Review comment: 1. Converted return type to List<String>. 2. Added Log.error() along with column name. 3. Added column to exception also. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org