deniskuzZ commented on a change in pull request #1415:
URL: https://github.com/apache/hive/pull/1415#discussion_r500497046
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands2.java
##########
@@ -2503,6 +2504,214 @@ public void testFullACIDAbortWithManyPartitions()
throws Exception {
List<String> rs = runStatementOnDriver("select a,b from " +
Table.ACIDTBLPART + " order by a");
Assert.assertEquals(stringifyValues(resultData2), rs);
}
+
+ @Test
+ public void testInsertIntoDPWithAborts() throws Exception {
+ d.destroy();
+ hiveConf.setVar(HiveConf.ConfVars.DYNAMICPARTITIONINGMODE, "nonstrict");
+ hiveConf.setIntVar(HiveConf.ConfVars.HIVE_COMPACTOR_ABORTEDTXN_THRESHOLD,
0);
+
hiveConf.setTimeVar(HiveConf.ConfVars.HIVE_COMPACTOR_ABORTEDTXN_TIME_THRESHOLD,
0, TimeUnit.MILLISECONDS);
+ int [][] resultData = new int[][] {{1,1}, {2,2}};
+ runStatementOnDriver("insert into " + Table.ACIDTBLPART + " partition(p)
values(1,1,'p1'),(2,2,'p1')");
+ verifyDeltaDirAndResult(1, Table.ACIDTBLPART.toString(), "p=p1",
resultData);
+
+ // forcing a txn to abort before addDynamicPartitions
+
hiveConf.setBoolVar(HiveConf.ConfVars.HIVETESTMODEFAILLOADDYNAMICPARTITION,
true);
Review comment:
What does this property do? Can't find any logic connected to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
