[GitHub] [hive] kgyrtkirk commented on a change in pull request #1553: HIVE-24231: Enhance shared work optimizer to merge scans with filters on both sides

[GitBox]

kgyrtkirk commented on a change in pull request #1553:
URL: https://github.com/apache/hive/pull/1553#discussion_r503169537



##########
File path: 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java
##########
@@ -159,9 +158,15 @@ public ParseContext transform(ParseContext pctx) throws 
SemanticException {
     // Gather information about the DPP table scans and store it in the cache
     gatherDPPTableScanOps(pctx, optimizerCache);
 
+    BaseSharedWorkOptimizer swo;
+    if (pctx.getConf().getBoolVar(ConfVars.HIVE_SHARED_WORK_MERGE_TS_SCHEMA)) {
+      swo = new BaseSharedWorkOptimizer();

Review comment:
       `SchemaAwareSharedWorkOptimizer` is the more strict version
   
   
https://github.com/apache/hive/blob/78d42f0321c846ee74794a58b94a92f65797430d/ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java#L591
   
   I just wanted to enable schema merge for all the optimizations - so I've 
moved it here




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org