kgyrtkirk commented on a change in pull request #1544:
URL: https://github.com/apache/hive/pull/1544#discussion_r504482010
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java
##########
@@ -233,6 +235,23 @@ public static ExprNodeGenericFuncDesc
and(List<ExprNodeDesc> exps) {
return new ExprNodeGenericFuncDesc(TypeInfoFactory.booleanTypeInfo, new
GenericUDFOPAnd(), "and", flatExps);
}
+ /**
+ * Create an expression for computing a hash by recursively hashing given
expressions by two:
+ * <pre>
+ * Input: HASH(A, B, C, D)
+ * Output: HASH(HASH(HASH(A,B),C),D)
+ * </pre>
+ */
+ public static ExprNodeGenericFuncDesc hash(List<ExprNodeDesc> exps) {
+ assert exps.size() >= 2;
+ ExprNodeDesc hashExp = exps.get(0);
+ for (int i = 1; i < exps.size(); i++) {
+ List<ExprNodeDesc> hArgs = Arrays.asList(hashExp, exps.get(i));
+ hashExp = new ExprNodeGenericFuncDesc(TypeInfoFactory.intTypeInfo, new
GenericUDFMurmurHash(), "hash", hArgs);
Review comment:
it seems like we have some inconsistency in `GenericUDFMurmurHash` which
is registered as `murmur_hash` in the `FunctionRegistry` ; however in the UDF's
annotation it only has `hash` - and here as well we use simply "hash".
a change like this will most likely cause a lot of q.out changes - could you
file a follow-up ticket?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
