mustafaiman commented on a change in pull request #1577:
URL: https://github.com/apache/hive/pull/1577#discussion_r508077019
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/DriverUtils.java
##########
@@ -61,6 +61,7 @@ public static void runOnDriver(HiveConf conf, String user,
throw new
IllegalArgumentException(JavaUtils.txnIdToString(compactorTxnId) +
" is not valid. Context: " + query);
}
+ sessionState.setSyncCleanup();
Review comment:
This switch is actually meant to be constant for a specific session.
I've put it as a setter as it seemed easier than putting it in constructor(many
changes to many file). Sync cleanup is used for compactor and stats updater
thread. Everything else will be async. I believe compactor and stats updater
use their own session repeatedly. Unless a regular query re-uses
compactor/statsupdater's session, there is no need to set it back to async.
I'll double check if this is the case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
