szlta opened a new pull request #1614:
URL: https://github.com/apache/hive/pull/1614


   HIVE-23741 introduced an optimization so that CacheTags are not stored on 
buffer level, but rather on file level, as one cache tag can only relate to one 
file. With this change a buffer->filecache reference was introduced so that the 
buffer's tag can be calculated with an extra indirection i.e. 
buffer.filecache.tag.
   
   However during buffer collision in putFileData method, we don't set the 
filecache reference of the collided (new) buffer: 
https://github.com/apache/hive/commit/2e18a7408a8dd49beecad8d66bfe054b7dc474da#diff-d2ccd7cf3042845a0812a5e118f82db49253d82fc86449ffa408903bf434fb6dR309-R311
   
   Later this cases NPE when the new (instantly decRef'ed) buffer is evicted.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to