pvargacl commented on a change in pull request #1592:
URL: https://github.com/apache/hive/pull/1592#discussion_r514923203
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
##########
@@ -1526,6 +1529,10 @@ private void
updateWSCommitIdAndCleanUpMetadata(Statement stmt, long txnid, TxnT
if (txnType == TxnType.MATER_VIEW_REBUILD) {
queryBatch.add("DELETE FROM \"MATERIALIZATION_REBUILD_LOCKS\" WHERE
\"MRL_TXN_ID\" = " + txnid);
}
+ if (txnType == TxnType.COMPACTION) {
Review comment:
I would prefer this method for two reasons:
1. To work correctly, the first point when we can update the CQ_NEXT_TXN_ID,
is inside the commitTxn, when we already have the lock for the txnId sequence.
Anywhere before that, there can be a txn, that will have a higher txnId than
the saved CQ_NEXT_TXN_ID and still not see the compaction as committed ->
causing the Cleaner to clean up deltas, that should be kept for that txn. So if
we don't do it in commitTxn, we only can do it after that, but that would mean,
that the update won't be part of the transaction, and can fail "silently"
2. In a follow up Jira, I need to provide a HMS notification for every
committed compaction, for that I would also need CQ_TXN_ID
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
