aasha commented on a change in pull request #1648:
URL: https://github.com/apache/hive/pull/1648#discussion_r520279514
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/CopyUtils.java
##########
@@ -112,11 +121,34 @@ public void copyAndVerify(Path destRoot,
List<ReplChangeManager.FileInfo> srcFil
srcFiles.add(new ReplChangeManager.FileInfo(sourceFs, origSrcPath,
null));
doCopyRetry(sourceFs, srcFiles, destRoot, proxyUser, useRegularCopy,
overwrite);
}
+ } catch (InterruptedException e) {
+ LOG.error("Failed to copy ", e);
+ throw new
IOException(ErrorMsg.REPL_FILE_SYSTEM_OPERATION_RETRY.getMsg());
} finally {
if (proxyUser != null) {
FileSystem.closeAllForUGI(proxyUser);
}
+ if (executorService != null) {
Review comment:
Please explain. This is in the finally block where it will always be
executed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
