belugabehr commented on a change in pull request #1629:
URL: https://github.com/apache/hive/pull/1629#discussion_r520712873
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/DriverTxnHandler.java
##########
@@ -67,7 +67,6 @@
import org.apache.hadoop.hive.ql.session.SessionState.LogHelper;
import org.apache.hadoop.util.StringUtils;
import org.apache.hive.common.util.ShutdownHookManager;
-import org.apache.hive.common.util.TxnIdUtils;
Review comment:
This is a good change, but please revert for this PR to keep it focused
on the Driver classes.
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/DriverFactory.java
##########
@@ -73,7 +73,7 @@ private static IReExecutionPlugin buildReExecPlugin(String
name) throws RuntimeE
if("reexecute_lost_am".equals(name)) {
return new ReExecuteLostAMQueryPlugin();
}
- if (name.equals("dagsubmit")) {
+ if ("dagsubmit".equals(name)) {
Review comment:
This is a good change, but please revert for this PR to keep it focused
on the Driver classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
