jcamachor commented on a change in pull request #1661:
URL: https://github.com/apache/hive/pull/1661#discussion_r522693729
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java
##########
@@ -1543,4 +1544,11 @@ public final boolean logicalEqualsTree(Operator<?> o) {
}
return true;
}
+
+ public void replaceTabAlias(String oldAlias, String newAlias) {
Review comment:
I am wondering whether `replaceTabAlias` should be in the operator conf
(`OperatorDesc`). There is an `AbstractOperatorDesc` which could hold the
default logic. Then it could be exposed here by simply calling
`conf.replaceTabAlias` (single implementation for all operators).
The advantage that I see is that you would force any custom operator that
does not inherit `AbstractOperatorDesc` to implement this method (I know we do
not introduce such operators that much -or at all- but it seems to me it may
make sense from the separation of concepts perspective).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
