asinkovits commented on a change in pull request #1665:
URL: https://github.com/apache/hive/pull/1665#discussion_r522500974
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/cache/EvictionListener.java
##########
@@ -20,4 +20,5 @@
public interface EvictionListener {
void notifyEvicted(LlapCacheableBuffer buffer);
+ void notifyEvictedBytes(long size);
Review comment:
Why is this required?
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java
##########
@@ -151,8 +151,10 @@ private LlapIoImpl(Configuration conf) throws IOException {
LowLevelCachePolicy
realCachePolicy =
useLrfu ? new LowLevelLrfuCachePolicy(minAllocSize, totalMemorySize,
conf) : new LowLevelFifoCachePolicy();
- // TODO: if realCachePolicy is not something that supports proactive
caching
- // turn the feature off (LLAP_IO_PROACTIVE_EVICTION_ENABLED) and log it
+ if (!(realCachePolicy instanceof ProactiveEvictingCachePolicy.Impl)) {
Review comment:
I think this would make sense in the mark phase as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
