szlta commented on a change in pull request #1675:
URL: https://github.com/apache/hive/pull/1675#discussion_r524094006
##########
File path:
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java
##########
@@ -147,7 +152,9 @@ public void notifyLock(LlapCacheableBuffer buffer) {
@Override
public void notifyUnlock(LlapCacheableBuffer buffer) {
-
+ if (proactiveEvictionEnabled) {
Review comment:
notifyUnlock(buffer) is invoked whenever a buffer was accessed (and the
read from it has been finished)
This here covers a very rare scenario, details in the test here:
https://github.com/apache/hive/pull/1675/files#diff-826be47ae17dbe2de96b3a40cf13fcc40604c5f630fd95d2732a646318ef33d4R307-R311
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
