kgyrtkirk commented on a change in pull request #1347: URL: https://github.com/apache/hive/pull/1347#discussion_r525343866
########## File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/PostgresTPCDS.java ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hive.metastore.dbinstall.rules; + +/** + * JUnit TestRule for Postgres metastore with TPCDS schema and stat information. + */ +public class PostgresTPCDS extends Postgres { + @Override + public String getDockerImageName() { + return "zabetak/postgres-tpcds-metastore:1.1"; + } + + @Override + public String getJdbcUrl() { + return "jdbc:postgresql://localhost:5432/metastore"; + } + + @Override + public String getHiveUser() { + return "hive"; + } + + @Override + public String getHivePassword() { + return "hive"; + } + + @Override + public void install() { + // Do not do anything since the postgres container contains a fully initialized Review comment: I think this needs to be updated during patch development to somehow pass the tests when the schema is changed (you cant run the tests against the previous schema if its incompatible) Lets see if we bump into any issues :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
