deniskuzZ commented on a change in pull request #1647:
URL: https://github.com/apache/hive/pull/1647#discussion_r527057925



##########
File path: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java
##########
@@ -1176,6 +1186,55 @@ protected void 
updateWSCommitIdAndCleanUpMetadata(Statement stmt, long txnid, Tx
               TxnDbUtil.getEpochFn(dbProduct) + " WHERE \"CQ_TXN_ID\" = " + 
txnid);
     }
   }
+
+  private CompactionInfo getCompactionByTxnId(Connection dbConn, long txnid) 
throws SQLException, MetaException {
+    CompactionInfo info = null;

Review comment:
       Wouldn't it be better if we wrap this with Optional?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to