kasakrisz commented on a change in pull request #1676:
URL: https://github.com/apache/hive/pull/1676#discussion_r527735262
##########
File path:
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveDecimalObjectInspector.java
##########
@@ -62,13 +62,4 @@ public int precision() {
}
Review comment:
We can remove it and it can also be removed from
`WritableConstant[Byte|Int|Long|Short]ObjectInspector`.
But it doesn't have such an effect like `scale()`. `scale()` plays a role in
converting to String but `precision()` is used only in functions
`GenericUDFBaseNumeric`, `GenericUDAFAverage`, `GenericUDAFSum` to determine
the result type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
