pvargacl commented on a change in pull request #1693:
URL: https://github.com/apache/hive/pull/1693#discussion_r528776095
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java
##########
@@ -219,23 +219,6 @@ void run(HiveConf conf, String jobName, Table t, Partition
p, StorageDescriptor
CompactionInfo ci, Worker.StatsUpdater su, IMetaStoreClient msc,
Directory dir)
throws IOException, HiveException {
- if(conf.getBoolVar(HiveConf.ConfVars.HIVE_IN_TEST) &&
conf.getBoolVar(HiveConf.ConfVars.HIVETESTMODEFAILCOMPACTION)) {
- throw new
RuntimeException(HiveConf.ConfVars.HIVETESTMODEFAILCOMPACTION.name() + "=true");
- }
-
- /*
- Try to run compaction via HiveQL queries.
- Compaction for MM tables happens here, or run compaction for Crud tables
if query-based compaction is enabled.
- todo Find a more generic approach to collecting files in the same logical
bucket to compact within the same task
- (currently we're using Tez split grouping).
- */
- QueryCompactor queryCompactor = QueryCompactorFactory.getQueryCompactor(t,
conf, ci);
Review comment:
This is so much cleaner, +100 for this :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
