viirya commented on a change in pull request #1715:
URL: https://github.com/apache/hive/pull/1715#discussion_r532090237
##########
File path:
serde/src/java/org/apache/hadoop/hive/serde2/avro/TypeInfoToSchema.java
##########
@@ -73,7 +74,7 @@ public Schema convert(List<String> columnNames,
List<TypeInfo> columnTypes,
}
private Schema.Field createAvroField(String name, TypeInfo typeInfo, String
comment) {
- return new Schema.Field(name, createAvroSchema(typeInfo), comment, null);
+ return new Schema.Field(name, createAvroSchema(typeInfo), comment,
JsonProperties.NULL_VALUE);
}
Review comment:
old:
https://github.com/apache/avro/blob/release-1.8.2/lang/java/avro/src/main/java/org/apache/avro/Schema.java#L393-L397
new:
https://github.com/apache/avro/blob/release-1.10.0/lang/java/avro/src/main/java/org/apache/avro/Schema.java#L579-L583
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
