deniskuzZ commented on a change in pull request #1716:
URL: https://github.com/apache/hive/pull/1716#discussion_r532575138
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -265,13 +267,14 @@ private static String idWatermark(CompactionInfo ci) {
}
/**
- * @return true if any files were removed
+ * @return true if the cleaner has removed all files rendered obsolete by
compaction
*/
private boolean removeFiles(String location, ValidWriteIdList writeIdList,
CompactionInfo ci)
throws IOException, NoSuchObjectException, MetaException {
Path locPath = new Path(location);
+ Map<Path, AcidUtils.HdfsDirSnapshot> dirSnapshots = null;
AcidUtils.Directory dir =
AcidUtils.getAcidState(locPath.getFileSystem(conf), locPath, conf, writeIdList,
Ref.from(
- false), false);
+ false), false, dirSnapshots);
Review comment:
how exactly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
