jcamachor commented on a change in pull request #1720:
URL: https://github.com/apache/hive/pull/1720#discussion_r533719602



##########
File path: storage-api/pom.xml
##########
@@ -177,6 +177,7 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-surefire-plugin</artifactId>
+        <version>3.0.0-M4</version>

Review comment:
       I don't think it's a major issue, I just find it easier to have all 
versions together in the properties block and I also thought this was the 
approach taken by Hive in general (I do not think this is formalized anywhere, 
just based on previous changes made to the top pom.xml file). I'll leave it up 
to you.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to