asinkovits commented on a change in pull request #1730:
URL: https://github.com/apache/hive/pull/1730#discussion_r535223946
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestFixAcidKeyIndex.java
##########
@@ -243,6 +233,12 @@ public void testInvalidKeyIndex() throws Exception {
checkInvalidKeyIndex(testFilePath);
// Try fixing, this should result in new fixed file.
fixInvalidIndex(testFilePath);
+
+ // Multiple stripes
+ createTestAcidFile(testFilePath, 12000, new FaultyKeyIndexBuilder());
+ checkInvalidKeyIndex(testFilePath);
+ // Try fixing, this should result in new fixed file.
+ fixInvalidIndex(testFilePath);
Review comment:
There is a validation in the tool itself after the recovery, so if the
index was still invalid, the output would be different.
https://github.com/asinkovits/hive/blob/HIVE-24475/ql/src/java/org/apache/hadoop/hive/ql/io/orc/FixAcidKeyIndex.java#L265
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
