pvary commented on pull request #1728: URL: https://github.com/apache/hive/pull/1728#issuecomment-738211024
> So, the answer is yes. The timestamps could be out of order. Before this patch the timestamps were in order as we locked the NEXT_EVENT_ID table with SELECT FOR UPDATE, so the timestamp was aligned with the EVENT_ID. (There might be some exceptions if some backend RDBMS reuses the value returned by the function now() in a single transaction, but I think we should overlook this for now 😄) After this PR the timestamps could become out of order. Which is IMHO an API change even if the order requirement is not documented. So the users should be aware of this change and we should seriously consider this before proceeding. Good to have you back and starting to cleaning up these stuff! Thanks, Peter ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
