miklosgergely commented on a change in pull request #1737: URL: https://github.com/apache/hive/pull/1737#discussion_r540075692
########## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/constraint/add/AbstractConstraintAnalyzer.java ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.ql.ddl.table.constraint.add; Review comment: As this class will be extended by both the add and drop constraint analyzer, it should be in the org.apache.hadoop.hive.ql.ddl.table.constraint package. ########## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/constraint/add/AlterTableAddConstraintAnalyzer.java ########## @@ -77,9 +82,23 @@ protected void analyzeCommand(TableName tableName, Map<String, String> partition throw new SemanticException(ErrorMsg.NOT_RECOGNIZED_CONSTRAINT.getMsg(constraintNode.getToken().getText())); } - Constraints constraints = new Constraints(primaryKeys, foreignKeys, null, uniqueConstraints, null, Review comment: According to the Hive checkstyle, the max line length is 120, please format the code according to that. ########## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/constraint/add/AlterTableAddConstraintAnalyzer.java ########## @@ -43,12 +48,12 @@ * Analyzer for add constraint commands. */ @DDLType(types = HiveParser.TOK_ALTERTABLE_ADDCONSTRAINT) -public class AlterTableAddConstraintAnalyzer extends AbstractAlterTableAnalyzer { +public class AlterTableAddConstraintAnalyzer extends AbstractConstraintAnalyzer { public AlterTableAddConstraintAnalyzer(QueryState queryState) throws SemanticException { super(queryState); } - @Override + @Override Review comment: No need to modify the indentation of this annotation ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
