kasakrisz commented on a change in pull request #1706:
URL: https://github.com/apache/hive/pull/1706#discussion_r540280345



##########
File path: ql/src/test/queries/clientpositive/materialized_view_create_rewrite.q
##########
@@ -5,6 +5,7 @@ set hive.support.concurrency=true;
 set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;
 set hive.strict.checks.cartesian.product=false;
 set hive.materializedview.rewriting=true;
+set hive.materializedview.rewriting.query.text=false;

Review comment:
       This test was written for calcite based rewrite and contains statements:
   ```
   create materialized view if not exists cmv_mat_view2_n4
   as select a, c from cmv_basetable_n10 where a = 3;
   ...
   explain
   select a, c from cmv_basetable_n10 where a = 3;
   ```
   If `hive.materializedview.rewriting.query.text` is enabled text based 
rewrite will rewrites this query and code execution never reaches calcite based 
rewrite logic. So the would lose its original purpose.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to