viirya commented on a change in pull request #1792:
URL: https://github.com/apache/hive/pull/1792#discussion_r545478347
##########
File path: ql/pom.xml
##########
@@ -880,6 +880,12 @@
<include>joda-time:joda-time</include>
<include>org.apache.calcite:*</include>
<include>org.apache.calcite.avatica:avatica</include>
+ <!-- include all of calcite's transitive dependencies as
well since
+ otherwise they'll be removed in assembly packaging -->
+ <include>net.hydromatic:eigenbase-properties</include>
+ <include>org.codehaus.janino:janino</include>
+ <include>org.codehaus.janino:commons-compiler</include>
+ <include>org.pentaho:pentaho-aggdesigner-algorithm</include>
Review comment:
BTW, I remember in the latest branch, the shading guava PR doesn't
include transitive dependencies like that. Do we also need to do it for the
branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
