dengzhhu653 commented on a change in pull request #1611:
URL: https://github.com/apache/hive/pull/1611#discussion_r546701496
##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java
##########
@@ -1002,11 +1002,19 @@ private String getSessionValue(String varName, String
varDefault) {
return varValue;
}
- // copy loginTimeout from driver manager. Thrift timeout needs to be in
millis
+ // use socketTimeout from jdbc connection url. Thrift timeout needs to be in
millis
private void setupLoginTimeout() {
- long timeOut = TimeUnit.SECONDS.toMillis(DriverManager.getLoginTimeout());
+ String socketTimeoutStr =
sessConfMap.getOrDefault(JdbcConnectionParams.SOCKET_TIMEOUT, "0");
+ long timeOut = 0;
Review comment:
Set the default value to 0 may cause problems for those elder clients
using DriverManager.loginTimeout to prevent the client from hang or return
quickly if there are some problems in HS2, users have to refactor the uri with
the socket timeout parameter after applying this. After all, there are some
preconditions should be met on the HIVE-22196: 1, There are different drivers
that created in the same jvm; 2, One of the driver sets the loginTimeout that
is inappropriate for others.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
