pvargacl commented on a change in pull request #1779:
URL: https://github.com/apache/hive/pull/1779#discussion_r546931357
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -3360,14 +3257,13 @@ public static Directory
getAcidStateFromCache(Supplier<FileSystem> fileSystem,
// compute and add to cache
if (recompute || (value == null)) {
- Directory dirInfo = getAcidState(fileSystem.get(), candidateDirectory,
conf,
+ AcidDirectory dirInfo = getAcidState(fileSystem.get(),
candidateDirectory, conf,
writeIdList, useFileIds, ignoreEmptyFiles);
value = new DirInfoValue(writeIdList.writeToString(), dirInfo);
if (value.dirInfo != null && value.dirInfo.getBaseDirectory() != null
&& value.dirInfo.getCurrentDirectories().isEmpty()) {
if (dirCacheDuration > 0) {
- populateBaseFiles(dirInfo, useFileIds, fileSystem);
Review comment:
The basefiles were populated and stored in cache, so they could be later
used in OrcInputFormat if no write happens to the table before the next query.
This is not necessary now, because ParsedBase will handle this when getFiles is
called, if the baseFiles are not there it will do the listing once and store
it. What is even better, if we are on S3 the files will be there already from
the first recursive listing, so the FS is not even called once.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
