pvary commented on a change in pull request #1797:
URL: https://github.com/apache/hive/pull/1797#discussion_r551331191
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java
##########
@@ -69,6 +69,12 @@ public boolean fillStorageFormat(ASTNode child) throws
SemanticException {
}
break;
case HiveParser.TOK_FILEFORMAT_GENERIC:
+ if (storageHandler != null) {
+ // Under normal circumstances, we should not get here (since STORED BY
and STORED AS are incompatible within the
+ // same command). Only scenario we can end up here is if a default
storage handler class is set in the config.
+ // In this case, we opt to ignore the STORED AS clause.
Review comment:
Maybe log?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
