nrg4878 commented on a change in pull request #1791:
URL: https://github.com/apache/hive/pull/1791#discussion_r552359001
##########
File path:
service/src/java/org/apache/hive/service/auth/AuthenticationProviderFactory.java
##########
@@ -76,6 +77,9 @@ public static PasswdAuthenticationProvider
getAuthenticationProvider(AuthMethods
return new CustomAuthenticationProviderImpl((conf == null) ?
AuthMethods.CUSTOM.getConf() : conf);
} else if (authMethod == AuthMethods.NONE) {
return new AnonymousAuthenticationProviderImpl();
+ } else if (authMethod == AuthMethods.SAML) {
+ //TODO right thing to do?
+ return new AnonymousAuthenticationProviderImpl();
Review comment:
not sure I understand how this works.
When auth is set to SAML on server, is this provider even called?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
