yongzhi commented on a change in pull request #1816:
URL: https://github.com/apache/hive/pull/1816#discussion_r552943505



##########
File path: 
spark-client/src/main/java/org/apache/hive/spark/client/AbstractSparkClient.java
##########
@@ -260,7 +265,7 @@ public void cancel(String jobId) {
     if (!properties.setReadable(false) || !properties.setReadable(true, true)) 
{
       throw new IOException("Cannot change permissions of job properties 
file.");
     }
-    properties.deleteOnExit();
+    sparkTmpProperties = properties;

Review comment:
       Is sparkTmpProperties only assigned when cancel called? Is there any 
normal scenario the properties need to be deleted?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to