pvargacl commented on a change in pull request #1839:
URL: https://github.com/apache/hive/pull/1839#discussion_r553599031
##########
File path:
ql/src/test/org/apache/hadoop/hive/metastore/txn/TestCompactionTxnHandler.java
##########
@@ -289,11 +290,15 @@ public void testMarkFailed() throws Exception {
assertFalse(txnHandler.checkFailedCompactions(ci));
// Add more failed compactions so that the total is exactly
COMPACTOR_INITIATOR_FAILED_THRESHOLD
- for (int i = 1 ; i <
conf.getIntVar(HiveConf.ConfVars.COMPACTOR_INITIATOR_FAILED_THRESHOLD); i++) {
+ for (int i = 1; i < MetastoreConf.getIntVar(conf,
MetastoreConf.ConfVars.COMPACTOR_INITIATOR_FAILED_THRESHOLD); i++) {
addFailedCompaction(dbName, tableName, CompactionType.MINOR,
partitionName, errorMessage);
}
// Now checkFailedCompactions() will return true
assertTrue(txnHandler.checkFailedCompactions(ci));
+ MetastoreConf.setTimeVar(conf,
MetastoreConf.ConfVars.COMPACTOR_INITIATOR_FAILED_RETRY_TIME, 1,
TimeUnit.MILLISECONDS);
+ // Now checkFailedCompactions() should ignore the treshold
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
