abstractdog edited a comment on pull request #1824: URL: https://github.com/apache/hive/pull/1824#issuecomment-756588127
> @abstractdog I had to introduce `compute_bit_vector_hll` and `compute_bit_vector_fm` because, vectorization is supported only for single argument functions. compute_bit_vector(arg1, arg2) will not vectorize. I think you can do it, refer to VectorUDAFBloomFilterMerge it uses "matches" function without the param, which is ok, param value is handled later: https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFBloomFilterMerge.java#L578 but then it's instantiated with parameters from conf: https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java#L1242 could this work for you? UPDATE: okay, I found where is prohibits parameters: https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java#L4531 I think this should be modified, I cannot see any problem with attaching constant parameters to aggregate expressions, and you can still do something like: if compute_bit_vector: -> handle constant parameter else: "Aggregations with > 1 parameter are only supported to 'x' and 'y' expression" ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
