belugabehr commented on a change in pull request #1853:
URL: https://github.com/apache/hive/pull/1853#discussion_r555265817
##########
File path: beeline/src/java/org/apache/hive/beeline/BeeLine.java
##########
@@ -2298,23 +2293,17 @@ public void addLocalDriverClazz(String driverClazz) {
supportedLocalDriver.add(driverClazz);
}
- Driver[] scanDrivers(String line) throws IOException {
- return scanDrivers(false);
- }
-
- Driver[] scanDrivers(boolean knownOnly) throws IOException {
Review comment:
This `knownOnly` flag is never used, so remove it. By extension, the
`scanDrivers(String line)` is also defunct.
Calling code turns the array into a Java Collection, so might as well just
change the return type here to return a Collection.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
